Parcourir la source

fixing inheritance and defining ArgumentType

logicp il y a 4 ans
Parent
commit
34a879cf02
3 fichiers modifiés avec 16 ajouts et 33 suppressions
  1. 1 1
      include/task/instagram_task.hpp
  2. 1 1
      include/task/task.hpp
  3. 14 31
      src/instagram_task.cpp

+ 1 - 1
include/task/instagram_task.hpp

@@ -9,7 +9,7 @@ class InstagramTask : public Task {
  public:
   bool isReady() override { return false; }
   virtual const TaskArguments getTaskArguments() override;
-  ~InstagramTask() override {}
+  virtual ~InstagramTask() override;
 };
 }  // namespace Task
 

+ 1 - 1
include/task/task.hpp

@@ -20,7 +20,7 @@ class Task {
  public:
   virtual bool isReady() = 0;
   virtual const TaskArguments getTaskArguments() = 0;
-  virtual ~Task() = 0;
+  virtual ~Task(){};
 };
 }  // namespace Task
 

+ 14 - 31
src/instagram_task.cpp

@@ -2,35 +2,18 @@
 
 using namespace Task;
 
-//  std::string header = "Learn to speak like native Korean speakers 🙆‍♀️🇰🇷";
-//  std::string description;
-//  std::string datetime;
-//  std::string promote_share = "Share the post through IG story if you enjoy the phrase 🙋‍♀️";
-//  std::string link_in_bio = "Subscribe to my YouTube channel (link 🔗in bio) to learn more about Korean language and
-//  culture ❤"; std::vector<std::string> hashtags; std::vector<std::string> requested_by; const char
-//  *requested_by_phrase = "The phrase was requested by "; std::vector<KFile> files; std::string user; bool is_video;
-const QVector<TaskArgument> instagram_task_arguments{TaskArgument{"header", "Text"},
-                                                     TaskArgument{"description", "Text"},
-                                                     TaskArgument{"datetime", "Datetime"},
-                                                     TaskArgument{"promote_share", "Text"},
-                                                     TaskArgument{"link_in_bio", "Text"},
-                                                     TaskArgument{"hashtags", "StringVector"},
-                                                     TaskArgument{"requested_by", "StringVector"},
-                                                     TaskArgument{"requested_by_phrase", "Text"},
-                                                     TaskArgument{"files", "FileVector"},
-                                                     TaskArgument{"user", "Text"},
-                                                     TaskArgument{"is_video", "Boolean"}};
+const TaskArguments InstagramTask::getTaskArguments() {
+  return QVector<TaskArgument>{TaskArgument{"header", Type::TEXT},
+                               TaskArgument{"description", Type::TEXT},
+                               TaskArgument{"datetime", Type::DATETIME},
+                               TaskArgument{"promote_share", Type::TEXT},
+                               TaskArgument{"link_in_bio", Type::TEXT},
+                               TaskArgument{"hashtags", Type::STRINGVECTOR},
+                               TaskArgument{"requested_by", Type::STRINGVECTOR},
+                               TaskArgument{"requested_by_phrase", Type::TEXT},
+                               TaskArgument{"files", Type::FILEVECTOR},
+                               TaskArgument{"user", Type::TEXT},
+                               TaskArgument{"is_video", Type::BOOLEAN}};
+}
 
-// const TaskArguments InstagramTask::getTaskArguments() {
-//  return QVector<TaskArgument>{TaskArgument{"header", "Text"},
-//                               TaskArgument{"description", "Text"},
-//                               TaskArgument{"datetime", "Datetime"},
-//                               TaskArgument{"promote_share", "Text"},
-//                               TaskArgument{"link_in_bio", "Text"},
-//                               TaskArgument{"hashtags", "StringVector"},
-//                               TaskArgument{"requested_by", "StringVector"},
-//                               TaskArgument{"requested_by_phrase", "Text"},
-//                               TaskArgument{"files", "FileVector"},
-//                               TaskArgument{"user", "Text"},
-//                               TaskArgument{"is_video", "Boolean"}};
-//}
+InstagramTask::~InstagramTask() {}