Parcourir la source

optimizing escapeText and escapeMessage functions to no longer call extraneous "contains" stl functions

logicp il y a 5 ans
Parent
commit
96750de9a3
1 fichiers modifiés avec 7 ajouts et 30 suppressions
  1. 7 30
      headers/util.hpp

+ 7 - 30
headers/util.hpp

@@ -58,39 +58,16 @@ struct KSession {
 };
 
 static QString escapeText(QString s) {
-    qDebug() << "Escaping text";
-    if (s.contains("\t")) {
-        s.replace("\t", "\\t");
-    }
-    if (s.contains("'")) {
-        qDebug() << "Replacing single quote";
-        if (s.contains('"')) {
-            s.replace('"', "\\\"");
-        }
-        s.replace("'", "'\"\'\"'");
-        return s;
-    }
-    if (s.contains('"')) {
-        s.replace('"', "\\\"");
-    }
-    return s;
+  s.replace("\t", "\\t");
+  s.replace('"', "\\\"");
+  s.replace("'", "'\"\'\"'");
+  return s;
 }
 
 static QString escapeMessage(QString s) {
-  if (s.contains("\t")) {
-    s.replace("\t", "\\t");
-  }
-  if (s.contains("'")) {
-    qDebug() << "Replacing single quote";
-    if (s.contains('"')) {
-      s.replace('"', "\\\"");
-    }
-    s.replace("'", "\'");
-    return s;
-  }
-  if (s.contains('"')) {
-    s.replace('"', "\\\"");
-  }
+  s.replace("\t", "\\t");
+  s.replace('"', "\\\"");
+  s.replace("'", "\'");
   return s;
 }